chore: pin geofence native SDK versions and example test wiring#609
Open
mrehan27 wants to merge 2 commits into
Open
chore: pin geofence native SDK versions and example test wiring#609mrehan27 wants to merge 2 commits into
mrehan27 wants to merge 2 commits into
Conversation
Contributor
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
iOS 4.6.0, Android 4.19.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Point the example at pre-release native builds so geofence can be tested before the native SDKs are released. Revert this commit once they ship. - Android: example uses the feature-branch snapshot + the central snapshot repo. - iOS: load the geofence-aware CocoaPods override from the feature branch, build against the customerio-ios feature branch, and pin the native iOS SDK back to 4.5.3 (the branch version) so pods resolve until 4.6.0 is released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mrehan27
force-pushed
the
mbl-1785-geofence-final
branch
from
a3ee796 to
e83e720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the geofence feature up to the native SDK versions that will ship it, and makes the example app buildable/testable against the pre-release native builds in the meantime.
This PR is intentionally two commits that must not be squashed:
Commit 1 — the real change we keep. Pins the native SDK versions that will contain geofence:
android/gradle.properties:cioSDKVersionAndroid4.18.2 → 4.19.0package.json:cioNativeiOSSdkVersion= 4.5.3 → = 4.6.0These versions aren't published yet, which is why Commit 2 exists.
Commit 2 — temporary scaffolding so CI and reviewers can build/test the example against pre-release native code. It only touches the example app + the iOS version pin:
example/android/build.gradle: snapshot Maven repos01.oss.sonatype.org→central.sonatype.com/repository/maven-snapshots(where the feature builds are published)example/android/gradle.properties: example usescioSDKVersionAndroid=feature-geofence-on-device-SNAPSHOTexample/ios/Podfile: load the geofence-aware CocoaPods override from the feature branch, build the app target against the customerio-iosfeature/geofence-on-devicebranch, and add an explicitCustomerIO/LocationGeofencegit pod (the umbrella subspec isn't on the released trunk spec yet)package.json: temporarily pinscioNativeiOSSdkVersionback to= 4.5.3(the feature branch's podspec version) so CocoaPods can resolve — this deliberately undoes Commit 1's iOS bump for testing onlyReverting Commit 2 restores Commit 1's production state exactly (
package.jsonreturns to= 4.6.0).Note for reviewers
Commit 2 is temporary test-only scaffolding and is reverted before this PR is merged. Please don't flag its changes as defects — they never reach the feature branch.
Verified locally
Merge plan
Commit 2 exists only so CI can build and anyone can test the CI builds while this PR is open. Before this PR is merged, Commit 2 is reverted, so only Commit 1 lands on
feature/geofence-on-device— Commit 2 never reaches the feature branch.Ticket
MBL-1785 — React Native: add geofencing support
PR stack
allowBackgroundDeliveryconfig🤖 Generated with Claude Code
Note
Low Risk
Changes are build/version pins and example-only temporary repo and Pod wiring; no runtime library logic changes in the diff shown.
Overview
Bumps the library default Android Customer.io native SDK from 4.18.2 → 4.19.0 in
android/gradle.propertiesso the React Native package targets the release that will ship geofence support.The example app is temporarily wired to pre-release native builds so CI and local testing can exercise geofence before those SDKs are published: Android uses
feature-geofence-on-device-SNAPSHOTand points snapshot resolution at Sonatype central (maven-snapshots); iOS loads the geofence CocoaPods override fromfeature/geofence-on-device, installs the non-production iOS SDK from that branch, and adds an explicitCustomerIO/LocationGeofencegit pod because the umbrella subspec is not on the released trunk spec yet. Comments in the example mark this scaffolding as revert before merge so only the version pin lands on the feature branch.Reviewed by Cursor Bugbot for commit e83e720. Bugbot is set up for automated code reviews on this repo. Configure here.